-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panicking when target triple has less than three elements #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+
bors bot
added a commit
that referenced
this pull request
Nov 22, 2022
932: Fix panicking when target triplets has less than three elements r=taiki-e a=Cryptex-github Currently the build script panic when the target triplets have less than three elements, for example `wasm32-wasi`, this PR fixes that issue. Fixes #931 Co-authored-by: Cryptex <[email protected]>
Build failed: |
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2022
933: v0.8: Prepare for the next release r=taiki-e a=taiki-e Backports #932 Changes: - crossbeam-epoch 0.9.13 - Fix build script bug introduced in 0.9.12. (#932) - crossbeam-queue 0.3.8 - Fix build script bug introduced in 0.9.12. (#932) - crossbeam-utils 0.8.14 - Fix build script bug introduced in 0.9.12. (#932) Co-authored-by: Cryptex <[email protected]> Co-authored-by: Taiki Endo <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 22, 2022
933: v0.8: Prepare for the next release r=taiki-e a=taiki-e Backports #932 Changes: - crossbeam-epoch 0.9.13 - Fix build script bug introduced in 0.9.12. (#932) - crossbeam-queue 0.3.8 - Fix build script bug introduced in 0.3.7. (#932) - crossbeam-utils 0.8.14 - Fix build script bug introduced in 0.8.13. (#932) Co-authored-by: Cryptex <[email protected]> Co-authored-by: Taiki Endo <[email protected]>
Published in crossbeam-utils 0.8.14, crossbeam-queue 0.3.8, and crossbeam-epoch 0.9.13. |
Cryptex-github
changed the title
Fix panicking when target triplets has less than three elements
Fix panicking when target triple has less than three elements
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build script panic when the target triple have less than three elements, for example
wasm32-wasi
, this PR fixes that issue.Fixes #931