Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panicking when target triple has less than three elements #932

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

Cryptex-github
Copy link
Contributor

@Cryptex-github Cryptex-github commented Nov 22, 2022

Currently the build script panic when the target triple have less than three elements, for example wasm32-wasi, this PR fixes that issue.

Fixes #931

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

bors bot added a commit that referenced this pull request Nov 22, 2022
932: Fix panicking when target triplets has less than three elements r=taiki-e a=Cryptex-github

Currently the build script panic when the target triplets have less than three elements, for example `wasm32-wasi`, this PR fixes that issue.

Fixes #931

Co-authored-by: Cryptex <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Build failed:

@taiki-e
Copy link
Member

taiki-e commented Nov 22, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

@bors bors bot merged commit 9b56854 into crossbeam-rs:master Nov 22, 2022
bors bot added a commit that referenced this pull request Nov 22, 2022
933: v0.8: Prepare for the next release r=taiki-e a=taiki-e

Backports #932

Changes:
- crossbeam-epoch 0.9.13
  - Fix build script bug introduced in 0.9.12. (#932)
- crossbeam-queue 0.3.8
  - Fix build script bug introduced in 0.9.12. (#932)
- crossbeam-utils 0.8.14
  - Fix build script bug introduced in 0.9.12. (#932)

Co-authored-by: Cryptex <[email protected]>
Co-authored-by: Taiki Endo <[email protected]>
bors bot added a commit that referenced this pull request Nov 22, 2022
933: v0.8: Prepare for the next release r=taiki-e a=taiki-e

Backports #932

Changes:
- crossbeam-epoch 0.9.13
  - Fix build script bug introduced in 0.9.12. (#932)
- crossbeam-queue 0.3.8
  - Fix build script bug introduced in 0.3.7. (#932)
- crossbeam-utils 0.8.14
  - Fix build script bug introduced in 0.8.13. (#932)

Co-authored-by: Cryptex <[email protected]>
Co-authored-by: Taiki Endo <[email protected]>
@taiki-e
Copy link
Member

taiki-e commented Nov 22, 2022

Published in crossbeam-utils 0.8.14, crossbeam-queue 0.3.8, and crossbeam-epoch 0.9.13.

@Cryptex-github Cryptex-github changed the title Fix panicking when target triplets has less than three elements Fix panicking when target triple has less than three elements Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Handling all Rust targets.
2 participants