Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore clippy::let_unit_value lint #858

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Ignore clippy::let_unit_value lint #858

merged 1 commit into from
Jul 1, 2022

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jul 1, 2022

No description provided.

@taiki-e
Copy link
Member Author

taiki-e commented Jul 1, 2022

bors r+

bors bot added a commit that referenced this pull request Jul 1, 2022
855: Miri: enable preemption again r=taiki-e a=RalfJung

Miri has a [work-around](rust-lang/miri#2248) for rust-lang/rust#55005 now.

Also, "check-number-validity" is on by default these days.  And I am not sure why "compare-exchange-weak-failure-rate=0.0" was set so let's see what happens when we remove it. :)

858: Ignore clippy::let_unit_value lint r=taiki-e a=taiki-e



Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Taiki Endo <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 1, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@taiki-e
Copy link
Member Author

taiki-e commented Jul 1, 2022

auto retry is not triggered or is very slow.

bors r-
bors r+

@bors
Copy link
Contributor

bors bot commented Jul 1, 2022

Canceled.

bors bot added a commit that referenced this pull request Jul 1, 2022
858: Ignore clippy::let_unit_value lint r=taiki-e a=taiki-e



Co-authored-by: Taiki Endo <[email protected]>
@taiki-e

This comment was marked as duplicate.

@bors
Copy link
Contributor

bors bot commented Jul 1, 2022

Already running a review

@bors
Copy link
Contributor

bors bot commented Jul 1, 2022

Build failed:

@taiki-e
Copy link
Member Author

taiki-e commented Jul 1, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 1, 2022

Build succeeded:

@bors bors bot merged commit 4b949c2 into master Jul 1, 2022
@bors bors bot deleted the clippy branch July 1, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant