Support AtomicCell<*64> arithmetics on targets that do not support Atomic*64 #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 8, 2022
767: Support AtomicCell<*64> arithmetics on targets that do not support Atomic*64 r=taiki-e a=taiki-e
This adds `AtomicCell<{i,u}64>::{fetch_add,fetch_sub,fetch_and,fetch_or,fetch_xor}` on targets that do not support `Atomic{I,U}64`.
This also adds `AtomicCell<{i,u}128>::{fetch_add,fetch_sub,fetch_and,fetch_or,fetch_xor}`.
These were provided in older versions of crossbeam-utils, but were unintentionally removed in 0.8.0 (11fbf05).
Co-authored-by: Taiki Endo <[email protected]>
taiki-e
force-pushed
the
atomic-cell-64-arithmetics
branch
from
9016759 to
3db81f9
Compare
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jan 8, 2022
769: Prepare for the next release r=taiki-e a=taiki-e - crossbeam-channel 0.5.1 -> 0.5.2 - Fix stacked borrows violations. (#763, #764) - crossbeam-epoch 0.9.5 -> 0.9.6 - Add `Atomic::fetch_update`. (#706) - crossbeam-queue 0.3.2 -> 0.3.3 - Fix stacked borrows violation in `ArrayQueue`. (#763) - crossbeam-utils 0.8.5 -> 0.8.6 - Re-add `AtomicCell<{i,u}64>::{fetch_add,fetch_sub,fetch_and,fetch_or,fetch_xor}` that were accidentally removed in 0.8.0 on targets that do not support `Atomic{I,U}64`. (#767) - Re-add `AtomicCell<{i,u}128>::{fetch_add,fetch_sub,fetch_and,fetch_or,fetch_xor}` that were accidentally removed in 0.8.0. (#767) Co-authored-by: Taiki Endo <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jan 23, 2022
775: Add mips-unknown-linux-gnu to CI r=taiki-e a=taiki-e Test 32-bit target that does not have AtomicU64/AtomicI64. This also adds a test for the regression that #767 caught. Co-authored-by: Taiki Endo <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 5, 2022
781: Fix unsoundness of AtomicCell<*64> arithmetics on 32-bit targets that support Atomic*64 r=taiki-e a=taiki-e The alignment of u64/i64 on a 32-bit target can be smaller than AtomicU64/AtomicI64. 32-bit targets without Atomic*64 (#767) and 64-bit targets are not affected by this issue. Co-authored-by: Taiki Endo <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 5, 2022
781: Fix unsoundness of AtomicCell<*64> arithmetics on 32-bit targets that support Atomic*64 r=taiki-e a=taiki-e The alignment of u64/i64 on a 32-bit target can be smaller than AtomicU64/AtomicI64. 32-bit targets without Atomic*64 (#767) and 64-bit targets are not affected by this issue. Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
AtomicCell<{i,u}64>::{fetch_add,fetch_sub,fetch_and,fetch_or,fetch_xor}on targets that do not supportAtomic{I,U}64.This also adds
AtomicCell<{i,u}128>::{fetch_add,fetch_sub,fetch_and,fetch_or,fetch_xor}.These were provided in older versions of crossbeam-utils, but were unintentionally removed in
0.8.00.7.1 (11fbf05).