fixed go.go to properly select over channels during the put operation in select_both #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'm curious how this change will change the benchmark results. |
Here are my teams benchmarking results. Note this was done in during a project involving implementing channels in the Flix programming language, so they additional test results are our additions. All tests were done on a machine 'node2x18a' at the University of Rochester cluster
|
bors bot
added a commit
that referenced
this pull request
May 19, 2021
697: fixed go.go to properly select over channels during the put operation in select_both r=taiki-e a=AidanGoldfarb Per the [crossbeam benchmark configuration](https://github.com/crossbeam-rs/crossbeam/blob/master/crossbeam-channel/benchmarks/README.md) the `select_both` function is defined as: > select_both: T threads send N / T messages each by selecting over T channels. T other threads receive N / T messages each by selecting over the T channels. Previously, the `select_both` function in [go.go](https://github.com/crossbeam-rs/crossbeam/blob/3e83987f258ab85a6573704ba538f2efdfe587c1/crossbeam-channel/benchmarks/go.go#L128) did not utilize the `select` statement while sending messages. Added the use of the select statement. Co-authored-by: Aidan <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the crossbeam benchmark configuration the
select_bothfunction is defined as:Previously, the
select_bothfunction in go.go did not utilize theselectstatement while sending messages. Added the use of the select statement.