Make Local less than 2048 bytes #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Sep 1, 2020
| @@ -55,7 +55,7 @@ use crate::sync::queue::Queue; | |||
|
|
|||
| /// Maximum number of objects a bag can contain. | |||
| #[cfg(not(feature = "sanitize"))] | |||
| const MAX_OBJECTS: usize = 64; | |||
| const MAX_OBJECTS: usize = 62; | |||
There was a problem hiding this comment.
fwiw, if make Local to be less than or equal to 1024 bytes, MAX_OBJECTS needs to be 30 (1016 bytes)
There was a problem hiding this comment.
If I didn't misunderstand @stjepang's this comment, It seems fine with less than half of what it is now, so it may be okay with this.
|
bors r=stjepang |
|
Build succeeded: |
exrook
pushed a commit
to exrook/crossbeam
that referenced
this pull request
Oct 7, 2020
This is just one of a few things to try related to crossbeam-rs#552. As a first step it would be interesting to see what kind of impact this has on Firefox automation builds. Some initial measurements are promising for builds with lots of cache misses, but this sort of thing is cumbersome to measure, so I'd like to try enabling this for the sccache client built in Mozilla automation to see the impact it has there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
MAX_OBJECTSto 62, and make the size ofLocalto 2040 bytes.Closes #551