Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests on Windows on CI #518

Closed
wants to merge 1 commit into from
Closed

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 25, 2020

crossbeam has some cfg(windows) code, but we don't test on CI. It would be nice to be able to test these with CI.

} else if #[cfg(windows)] {

Travis's Windows support was experimental and very slow, but GitHub Actions' Windows support relatively fast. Hopefully we can add this to our CI.

@taiki-e taiki-e changed the title WIP: Enable tests on Windows on CI Enable tests on Windows on CI May 25, 2020
@taiki-e taiki-e marked this pull request as ready for review May 25, 2020 01:52
# These jobs don't actually test anything, but they're used to tell bors the
# build completed, as there is no practical way to detect when a workflow is
# successful listening to webhooks only.
#
# ALL THE PREVIOUS JOBS NEEDS TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
Copy link
Member Author

@taiki-e taiki-e May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a realistic way for bors to receive build status from Github Actions, which do a lot of jobs (It's used in rust-lang/rust, rust-lang/clippy, etc. Previously we had to manually manage all job names.)

@taiki-e taiki-e force-pushed the windows branch 2 times, most recently from 073a81a to e9a5cbb Compare May 25, 2020 02:02
@taiki-e
Copy link
Member Author

taiki-e commented May 25, 2020

(I originally tried to add both macOS and Windows to the CI, but I had a lot of locally non-reproducible errors with macOS, so I opened a windows-only PR for now.)

@taiki-e
Copy link
Member Author

taiki-e commented May 25, 2020

Now, this should be ready for review.

@taiki-e taiki-e requested review from a user and jeehoonkang May 25, 2020 02:14
Copy link
Contributor

@jeehoonkang jeehoonkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few questions.

ci/crossbeam-epoch.sh Outdated Show resolved Hide resolved
crossbeam-channel/examples/stopwatch.rs Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jeehoonkang
Copy link
Contributor

bors r+

@taiki-e
Copy link
Member Author

taiki-e commented May 25, 2020

Hm, bors-ng doesn't seem to handle the change from fork to bors.toml correctly?

Related: bors-ng/bors-ng#806

bors r-

@taiki-e
Copy link
Member Author

taiki-e commented May 25, 2020

So, I'll open the PR from this repo's branch with the same commit.

@taiki-e
Copy link
Member Author

taiki-e commented May 25, 2020

Closing in favor of #519

@taiki-e taiki-e closed this May 25, 2020
@taiki-e taiki-e deleted the windows branch May 25, 2020 16:00
bors bot added a commit that referenced this pull request May 25, 2020
519: Enable tests on Windows on CI r=taiki-e a=taiki-e

Replaces #518 (changing bors-ng configuration from a forked branch doesn't seem to work well...)

Co-authored-by: Taiki Endo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants