Merge #944

944: Run cargo-careful in CI r=taiki-e a=taiki-e https://github.com/RalfJung/cargo-careful This allows to catch UB like #940. Co-authored-by: Taiki Endo <[email protected]>
crossbeam-rs · Dec 27, 2022 · 1acda58 · 1acda58
2 parents 8903ff0 + ec4fee1
commit 1acda58
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -167,6 +167,18 @@ jobs:
       - name: miri
         run: ./ci/miri.sh
 
+  # Run cargo-careful.
+  careful:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Install Rust
+        run: rustup toolchain install nightly --component rust-src && rustup default nightly
+      - name: Install cargo-careful
+        run: cargo install cargo-careful --locked --debug
+      - name: Run cargo-careful
+        run: ./ci/careful.sh
+
   # Run sanitizers.
   san:
     runs-on: ubuntu-latest
@@ -222,6 +234,7 @@ jobs:
       - rustfmt
       - clippy
       - miri
+      - careful
       - san
       - loom
       - docs

diff --git a/ci/careful.sh b/ci/careful.sh
@@ -0,0 +1,8 @@
+#!/bin/bash
+set -euxo pipefail
+IFS=$'\n\t'
+cd "$(dirname "$0")"/..
+
+export RUSTFLAGS="${RUSTFLAGS:-} -Z randomize-layout"
+
+cargo careful test --all --all-features --exclude benchmarks -- --test-threads=1