Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86_64-linux-android build support #98

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

malbarbo
Copy link
Contributor

No description provided.

@malbarbo
Copy link
Contributor Author

Target x86_64-android-linux was recently added.

@japaric
Copy link
Contributor

japaric commented Apr 29, 2017

Thanks, @malbarbo!

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit 528480f has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit 528480f with merge 528480f...

@homunkulus
Copy link
Contributor

💔 Test failed - status-travis

@malbarbo
Copy link
Contributor Author

The error seems to be unrelated. Let's try again?

@japaric
Copy link
Contributor

japaric commented May 17, 2017

The PowerPC problem should be fixed now.

@homunkulus r+

@homunkulus
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@homunkulus
Copy link
Contributor

📌 Commit 528480f has been approved by japaric

@japaric
Copy link
Contributor

japaric commented May 17, 2017

@homunkulus retry

@homunkulus
Copy link
Contributor

⌛ Testing commit 528480f with merge bdceaa9...

japaric pushed a commit that referenced this pull request May 17, 2017
Add x86_64-linux-android build support
@homunkulus
Copy link
Contributor

💔 Test failed - status-travis

@malbarbo
Copy link
Contributor Author

Unrelated again?

@japaric
Copy link
Contributor

japaric commented May 19, 2017

+cargo update -p time
error: package id specification time matched no packages

https://travis-ci.org/japaric/cross/jobs/227169983#L6898

@malbarbo
Copy link
Contributor Author

I saw the wrong log, sorry. I think that chrono (and time) dependency (rust-lang/cargo#4069) was removed in the middle of the test! That bad luck! Maybe we can fix a revision...

Fixed now.

@japaric
Copy link
Contributor

japaric commented May 20, 2017

Thanks. Let's try again.

@homunkulus r+

BTW, could you please next time push a new commit rather than amend the last one. That way it's easier for me to see the latest change you made.

@homunkulus
Copy link
Contributor

📌 Commit 125db52 has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit 125db52 with merge fc7b72b...

japaric pushed a commit that referenced this pull request May 20, 2017
Add x86_64-linux-android build support
@homunkulus
Copy link
Contributor

💔 Test failed - status-travis

@malbarbo
Copy link
Contributor Author

The problem is the new lint rust-lang/rust#41907. How should we proceed? Use a specific version of nightly?

It seems that using nightly and head of git repositories of cargo, etc, is a fragile approach...

@malbarbo
Copy link
Contributor Author

BTW, could you please next time push a new commit rather than amend the last one. That way it's easier for me to see the latest change you made.

Oh, sorry for that.

@malbarbo
Copy link
Contributor Author

@japaric How can we proceed with this?

@japaric
Copy link
Contributor

japaric commented Jun 1, 2017

There's a fix for the unused macro warning / error in rust-lang/compiler-builtins#165.

We could shield us from some of these problems using "--cap-lints" (I think that was the name of the flag) to ignore warnings / errors due to warnings.

@malbarbo
Copy link
Contributor Author

malbarbo commented Jun 1, 2017

Thanks for fixing it. According to https://github.com/rust-lang/rfcs/blob/master/text/1193-cap-lints.md the option is --cap-lints allow, but cross does not allows passing args to rustc via RUSTFLAGS...

@malbarbo
Copy link
Contributor Author

malbarbo commented Jun 1, 2017

Let's try again?

@japaric
Copy link
Contributor

japaric commented Jun 1, 2017

@homunkulus r+

@homunkulus
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@homunkulus
Copy link
Contributor

📌 Commit 125db52 has been approved by japaric

@japaric
Copy link
Contributor

japaric commented Jun 1, 2017

@homunkulus retry

@homunkulus
Copy link
Contributor

⌛ Testing commit 125db52 with merge e9ad79f...

japaric pushed a commit that referenced this pull request Jun 1, 2017
Add x86_64-linux-android build support
@homunkulus
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: japaric
Pushing e9ad79f to master...

@homunkulus homunkulus merged commit 125db52 into cross-rs:master Jun 2, 2017
@malbarbo malbarbo deleted the android-x86-64 branch October 20, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants