Enable copying symlinks when using remote docker. #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses the comments mentioned here. |
This handles the reads the link dst from the symlink when using temporary directories, and creates a softlink to the path (keeping relative and absolute symlinks valid) in the temporary directory, which is then copied with the same permissions over the dst filesystem. This should not keep the same metadata, but since we fingerprint source files, this should not matter.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the reads the link dst from the symlink when using temporary directories, and creates a softlink to the path (keeping relative and absolute symlinks valid) in the temporary directory, which is then copied with the same permissions over the dst filesystem. This should not keep the same metadata, but since we fingerprint source files, this should not matter.
If symlinks are created, it issues a warning that there might be bugs that the file pointed to by the symlink is not mounted and the build may fail in that case.