-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dockerfile for cross. #878
Conversation
For some reason, the tags aren't working: I might have to override some of the envvars. |
bors try --target cross |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I managed to get this to work by effectively skipping the test if it was a Docker image for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this entry point approach not incur quite a bit of startup?
Also, this doesnt test the code in the branch or even local base, but current main
Instead of doing that, better approach I think would be to make something similar to Line 70 in eb2b8ad
The first alternative is correct also, however in if statements you dont need |
Yeah I probably need another test script or something. Also, it's probably a good idea to move this to Ubuntu, since all our other images are. I think having a single Alpine image probably isn't worth it. It's also a much larger image since it needs a redundant Maybe the integration tests for docker-in-docker could be based off of this? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
53a737c
to
953ea7f
Compare
I changed the Dockerfile context to the workspace root, and then use that in the build process, so we can copy over the entire project over from the current source code, to ensure the image reflects the current project state. bors try --target cross |
This comment was marked as outdated.
This comment was marked as outdated.
41ca68c
to
a648e69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One thing missing is changing the label for title, it should probably be simply "cross" or similar
bors try --target cross |
tryBuild succeeded: |
This uses the installs Docker from the official sources using the latest Ubuntu image stable, and installs the latest stable Rust version internally. Cross is installed from the latest git (locked), which when tagged will work well with our releases. It exports the environment variable `CROSS_CONTAINER_IN_CONTAINER` so everything should work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
bors r=Emilgardis |
Build succeeded: |
This uses the official Docker docker-in-docker image for the latest stable, and installs the latest stable Rust version internally. It uses an entrypoint to ensure cargo is on the path, and that cross is installed from the latest git (locked), which when tagged will work well with our releases. It exports the environment variable
CROSS_CONTAINER_IN_CONTAINER
so everything should work as expected.Closes #468.
Replaces #667.