Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore the CARGO environment variable. #868

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Ignore the CARGO environment variable. #868

merged 1 commit into from
Jun 26, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Provides behavior consistent with cargo itself, which also ignores it.

Closes #864.
Supersedes #865.
Partially reverts #808.

@Alexhuszagh
Ignore the CARGO environment variable.
b5b43b1 
Provides behavior consistent with `cargo` itself, which also ignores it.

Closes cross-rs#864.
Supersedes cross-rs#865.
Partially reverts cross-rs#808.
@Alexhuszagh Alexhuszagh added this to the v0.2.3 milestone Jun 26, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 26, 2022 16:12
@Alexhuszagh
Copy link
Contributor Author

Alexhuszagh commented Jun 26, 2022 •
edited
Loading

See this comment for why this is the correct behavior. We already rely on rustup being on the path, so we should expect users who want a custom path to ensure that cargo is also on the path, rather than found via a custom environment variable.

@Emilgardis
Copy link
Member

Yes, this makes sense.

Emilgardis
Emilgardis approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@Alexhuszagh Alexhuszagh mentioned this pull request Jun 26, 2022
Closed
@bors
Copy link
Contributor

bors bot commented Jun 26, 2022

Build succeeded:

@bors bors bot merged commit 3659673 into cross-rs:main Jun 26, 2022
@Alexhuszagh Alexhuszagh deleted the cargo_env branch June 27, 2022 00:37
@Alexhuszagh Alexhuszagh mentioned this pull request Jun 27, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.

cross 0.2.2 hangs forever when CARGO env var set to cross
2 participants
@Alexhuszagh @Emilgardis