Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring in xtask. #866

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Minor refactoring in xtask. #866

merged 1 commit into from
Jun 27, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Ensure general-purpose are in xtask::util, useful for adding more features down the line.

@Alexhuszagh Alexhuszagh added meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog) labels Jun 26, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 26, 2022 14:14
@Alexhuszagh
Minor refactoring in xtask.
4cfb7af 
Ensure general-purpose are in `xtask::util`, useful for adding more
features down the line.
@Alexhuszagh
Copy link
Contributor Author

Alexhuszagh commented Jun 26, 2022 •
edited
Loading

I've got a test for UBUNTU_BASE based off of this PR. Not sure if I should roll both into one, or submit them as separate PRS:

https://github.com/Alexhuszagh/cross/tree/dockerfile

That PR will be necessary for #591.

Emilgardis
Emilgardis approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 27, 2022

Build succeeded:

@bors bors bot merged commit 021a103 into cross-rs:main Jun 27, 2022
@Emilgardis Emilgardis added this to the v0.2.3 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
meta issues/PRs related to the maintenance of the crate. no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexhuszagh @Emilgardis