build images weekly, without cache #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this gives me the idea to also start making progress into buildx, it'd be cool if |
Emilgardis
commented
Jun 13, 2022
Emilgardis
force-pushed
the
no-cache-runs
branch
4 times, most recently
from
d136a91 to
92f5a4a
Compare
|
going to split this out into two prs |
Emilgardis
force-pushed
the
no-cache-runs
branch
from
92f5a4a to
b22604c
Compare
Emilgardis
changed the title
|
depends on #791 |
Emilgardis
force-pushed
the
no-cache-runs
branch
from
b22604c to
50c4eb0
Compare
|
this could also maybe implement parts of #610, checking that mounts works correctly |
Emilgardis
force-pushed
the
no-cache-runs
branch
from
50c4eb0 to
c2f6a1f
Compare
Emilgardis
commented
Jun 16, 2022
Comment on lines
+104
to
+114
| .map(|m| { | ||
| format!( | ||
| "{}{}", | ||
| m.target, | ||
| if let Some(sub) = &m.sub { | ||
| format!(".{sub}") | ||
| } else { | ||
| <_>::default() | ||
| } | ||
| ) | ||
| }) |
There was a problem hiding this comment.
fixed this too, apparently it went away in some rebase somewhere
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.