Reduce Android image sizes. #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otavio
approved these changes
Jun 3, 2022
|
bors r+ |
|
Merge conflict. |
|
@Alexhuszagh can you rebase? |
Alexhuszagh
force-pushed
the
android_minimal
branch
2 times, most recently
from
037fb19 to
9e87b5f
Compare
bors bot
added a commit
that referenced
this pull request
Jun 3, 2022
747: Reduce Android image sizes. r=otavio,emilgardis a=Alexhuszagh Delete unused toolchains to save ~600MB in our total image sizes. This is done by removing the toolchains for other targets in `/android-ndk/sysroot/usr/lib/`. Closes #739. Co-authored-by: Alex Huszagh <[email protected]>
|
Build failed: |
|
Ok this has issues for aarch64 and i686, not sure why but I'm marking as a draft until I fix this. I checked armv7 and arm, so I assumed this was working. Oh right, we have the following in the Dockerfiles: RUN /android-ndk.sh x86 28
RUN /android-ndk.sh arm64 28 |
Delete unused toolchains to save ~600MB in our total image sizes. This is done by removing the toolchains for other targets in `/android-ndk/sysroot/usr/lib/`. Closes cross-rs#739.
Alexhuszagh
force-pushed
the
android_minimal
branch
from
9e87b5f to
da9aa4e
Compare
|
bors try --target android |
|
Ok I've fixed these issues by converting the provided architecture to the triple prefix: local triple_arch="${arch}"
case "${arch}" in
arm64)
triple_arch="aarch64"
;;
x86)
triple_arch="i686"
;;
esac
triples=(...)
for triple in "${triples[@]}"; do
if ! [[ "${triple}" =~ ^"${triple_arch}".* ]]; then
rm -rf "/android-ndk/sysroot/usr/lib/${triple}"
fi
done |
tryBuild succeeded: |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete unused toolchains to save ~600MB in our total image sizes. This is done by removing the toolchains for other targets in
/android-ndk/sysroot/usr/lib/.Closes #739.