Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cross debugging and runners on Android. #725

Merged
merged 1 commit into from
May 28, 2022
Merged

Support cross debugging and runners on Android. #725

merged 1 commit into from
May 28, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Support the CROSS_DEBUG and CROSS_RUNNER environment variables for android runners.

This allows us to both get debugging information for the Android runner (similar to the Linux runner) and also use a native runner for Android (defaults to Qemu). It also fixes a minor bug where the Android runner was not used on armv7-linux-androideabi.

@Alexhuszagh Alexhuszagh requested a review from a team as a code owner May 28, 2022 19:01
@Alexhuszagh Alexhuszagh force-pushed the android_cross_runner branch from ecd562c to a30f60c Compare May 28, 2022 19:06
@Alexhuszagh
Copy link
Contributor Author

bors try android

bors bot added a commit that referenced this pull request May 28, 2022
@bors
Try #725: android
3178db2
@Alexhuszagh
Support cross debugging and runners on Android.
a29d466 
Support the `CROSS_DEBUG` and `CROSS_RUNNER` environment variables for
android runners.
@Alexhuszagh Alexhuszagh force-pushed the android_cross_runner branch from a30f60c to a29d466 Compare May 28, 2022 19:12
@bors
Copy link
Contributor

bors bot commented May 28, 2022

try

Build failed:

@Alexhuszagh
Copy link
Contributor Author

bors try --target android

bors bot added a commit that referenced this pull request May 28, 2022
@bors
Try #725: --target android
81f7603
@bors
Copy link
Contributor

bors bot commented May 28, 2022

try

Build succeeded:

Emilgardis
Emilgardis approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alexhuszagh
Copy link
Contributor Author

bors r+

@Emilgardis
Copy link
Member

fyi, try to use bors r=reviewer when someone else has reviewed but not explicitly done bors r+ themselves, doesn't really matter in our workflow but good to know 👍

@Alexhuszagh
Copy link
Contributor Author

fyi, try to use bors r=reviewer when someone else has reviewed but not explicitly done bors r+ themselves, doesn't really matter in our workflow but good to know +1

Thank you, good to know.

@bors
Copy link
Contributor

bors bot commented May 28, 2022

Build succeeded:

@bors bors bot merged commit c28909f into cross-rs:main May 28, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
A-android Area: android targets container-images enhancement
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexhuszagh @Emilgardis