Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert --target-dir to use absolute paths. #713

Merged
merged 1 commit into from
May 24, 2022

Conversation

Alexhuszagh
Copy link
Contributor

@Alexhuszagh Alexhuszagh commented May 24, 2022

Converts relative target directories to absolute paths, to avoid creating the target directory in the sysroot. This keeps the prior behavior if the provided target directory is an absolute path.

Fixes #581.

@Alexhuszagh Alexhuszagh requested a review from a team as a code owner May 24, 2022 16:01
@Alexhuszagh Alexhuszagh force-pushed the relative_target_dir branch from c5f2f67 to e647e63 Compare May 24, 2022 16:04
CHANGELOG.md Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
Converts relative target directories to absolute paths, to avoid creating the target directory in the sysroot.

Fixes cross-rs#581.
@Alexhuszagh Alexhuszagh force-pushed the relative_target_dir branch from e647e63 to 2504e04 Compare May 24, 2022 17:02
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented May 24, 2022

Build succeeded:

@bors bors bot merged commit 0adbce2 into cross-rs:main May 24, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added enhancement no-ci-targets PRs that do not affect any cross-compilation targets. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--target-dir results in failed to create directory /target/release
2 participants