Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Emscripten targets to latest official Docker image #709

Merged
merged 3 commits into from
May 9, 2022
Merged

Update Emscripten targets to latest official Docker image #709

merged 3 commits into from
May 9, 2022

Conversation

Jules-Bertholet
Copy link
Contributor

No description provided.

@Jules-Bertholet Jules-Bertholet requested a review from a team as a code owner May 8, 2022 21:09
svenstaro
svenstaro approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty solid to me. The old image was mega old.

Emilgardis
Emilgardis requested changes May 9, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Jules-Bertholet Jules-Bertholet requested a review from Emilgardis May 9, 2022 18:09
Emilgardis
Emilgardis approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented May 9, 2022

Build succeeded:

@bors bors bot merged commit 4deac83 into cross-rs:main May 9, 2022
@Jules-Bertholet Jules-Bertholet deleted the update-emscripten branch May 9, 2022 18:59
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added enhancement A-emscripten Area: emscripten targets labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

@svenstaro svenstaro svenstaro approved these changes

Assignees
No one assigned
Labels
A-emscripten Area: emscripten targets enhancement
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Jules-Bertholet @svenstaro @Emilgardis @Alexhuszagh