-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn on unknown fields and confusable targets #681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on [build]
default-target = "x86_64-unknown-linux-gnu"
[target.x86-64-unknown-linux-gnu]
image = "aaa:aa"
aaaa = "a"
aaaaa = "a" this will warn
|
reitermarkus
reviewed
Apr 6, 2022
reitermarkus
reviewed
Apr 6, 2022
Emilgardis
force-pushed
the
unknown_confusing_fields
branch
from
April 6, 2022 08:20
453b9ae
to
82604e9
Compare
rebased the pr to incorporate the suggestions edit: |
Emilgardis
force-pushed
the
unknown_confusing_fields
branch
from
April 6, 2022 08:21
82604e9
to
9a8ba7b
Compare
Emilgardis
force-pushed
the
unknown_confusing_fields
branch
from
April 6, 2022 08:22
9a8ba7b
to
9dd3e9f
Compare
Emilgardis
force-pushed
the
unknown_confusing_fields
branch
from
April 6, 2022 08:24
9dd3e9f
to
53ba9ac
Compare
reitermarkus
approved these changes
Apr 6, 2022
bors r=reitermarkus |
Build succeeded: |
Alexhuszagh
added
enhancement
no-ci-targets
PRs that do not affect any cross-compilation targets.
labels
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes #643