Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn on unknown fields and confusable targets #681

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

Emilgardis
Copy link
Member

also fixes #643

@Emilgardis Emilgardis requested a review from a team as a code owner April 5, 2022 21:23
@Emilgardis
Copy link
Member Author

Emilgardis commented Apr 5, 2022

on

[build]
default-target = "x86_64-unknown-linux-gnu"

[target.x86-64-unknown-linux-gnu]
image = "aaa:aa"
aaaa = "a"
aaaaa = "a"

this will warn

Warning: found unused key(s) in in Cross configuration:
 > target.x86-64-unknown-linux-gnu.aaaa, target.x86-64-unknown-linux-gnu.aaaaa
Warning: a target named "x86-64-unknown-linux-gnu" is mentioned in the Cross configuration, but the current specified target is "x86_64-unknown-linux-gnu".
 > Is the target misspelled in the Cross configuration?

The formatting should probably be a bit standardized :)

src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@Emilgardis Emilgardis force-pushed the unknown_confusing_fields branch from 453b9ae to 82604e9 Compare April 6, 2022 08:20
@Emilgardis
Copy link
Member Author

Emilgardis commented Apr 6, 2022

rebased the pr to incorporate the suggestions

edit:
note to self: don't rebase without having had your coffee

@Emilgardis Emilgardis force-pushed the unknown_confusing_fields branch from 82604e9 to 9a8ba7b Compare April 6, 2022 08:21
@Emilgardis Emilgardis force-pushed the unknown_confusing_fields branch from 9a8ba7b to 9dd3e9f Compare April 6, 2022 08:22
@Emilgardis Emilgardis force-pushed the unknown_confusing_fields branch from 9dd3e9f to 53ba9ac Compare April 6, 2022 08:24
@Emilgardis
Copy link
Member Author

bors r=reitermarkus

@bors
Copy link
Contributor

bors bot commented Apr 6, 2022

Build succeeded:

@bors bors bot merged commit 1496558 into cross-rs:main Apr 6, 2022
@Emilgardis Emilgardis deleted the unknown_confusing_fields branch April 6, 2022 15:01
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added enhancement no-ci-targets PRs that do not affect any cross-compilation targets. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linker fails with cross, but builds otherwise inside the same docker image
3 participants