Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bors try arguments. #652

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Support bors try arguments. #652

merged 5 commits into from
Mar 16, 2022

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 15, 2022

Allow trying individual targets.

Closes #651.

@reitermarkus reitermarkus requested a review from a team as a code owner March 15, 2022 22:06
@reitermarkus
Copy link
Member Author

bors try --target dummy

bors bot added a commit that referenced this pull request Mar 15, 2022
@Emilgardis
Copy link
Member

if only there was a way to actually debug events properly :/

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build failed:

@Emilgardis Emilgardis linked an issue Mar 15, 2022 that may be closed by this pull request
@Emilgardis
Copy link
Member

bors try --target dummy_.*

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try --target "dummy"

bors bot added a commit that referenced this pull request Mar 15, 2022
@reitermarkus
Copy link
Member Author

bors try --target "dummy"

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try --target "dummy"

bors bot added a commit that referenced this pull request Mar 15, 2022
@reitermarkus
Copy link
Member Author

bors try --target dummy_.*

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try-

@reitermarkus
Copy link
Member Author

bors try --target dummy_.*

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try --target dummy_.*

bors bot added a commit that referenced this pull request Mar 15, 2022
@Emilgardis
Copy link
Member

failing on a non-matched target instead of trying to correct the matrix is what should be done imo. Don't think it's possible to do conditional matrices

@reitermarkus
Copy link
Member Author

I'm not quite sure what you mean.

@reitermarkus
Copy link
Member Author

bors try --target freebsd

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Already running a review

@reitermarkus
Copy link
Member Author

bors try-

@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

try

Build succeeded:

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 16, 2022
@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

try

Build succeeded:

@reitermarkus reitermarkus force-pushed the bors-try-args branch 2 times, most recently from 3b722cc to 583839a Compare March 16, 2022 13:50
@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 16, 2022
@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 16, 2022
@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

try

Build succeeded:

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 16, 2022
@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

try

Build succeeded:

@reitermarkus
Copy link
Member Author

@Emilgardis, this should be good to go.

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, small nit not related to the pr, can be done separately

@@ -5,6 +5,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

- #652 - Allow trying individual targets via bors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add 609 to the changelog also :)

@reitermarkus
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

Build succeeded:

@bors bors bot merged commit cff2559 into cross-rs:main Mar 16, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added meta issues/PRs related to the maintenance of the crate. no-ci-targets PRs that do not affect any cross-compilation targets. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta issues/PRs related to the maintenance of the crate. no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add way to manually trigger a workflow run for certain target
4 participants