Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if there's a file cross.toml with wrong capitalization #601

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

denisfalqueto
Copy link
Contributor

I've lost some good days struggling with errors because I've created a file named cross.toml and it wouldn't affect the build, because the name was not capitalized correctly. So, I think it should be cool if cross could warn the user if there's a file with a capitalization problem present on the project root.

@denisfalqueto denisfalqueto requested review from Dylan-DPC-zz and a team as code owners October 15, 2021 18:06
@otavio
Copy link
Contributor

otavio commented Mar 17, 2022

@maintainers, this seems very simple and useful.

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 17, 2022

Build succeeded:

@bors bors bot merged commit 8863b33 into cross-rs:main Mar 17, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added enhancement no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect any cross-compilation targets. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants