Do no panic when passed empty string as argument. closes #466 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudipghimire533
changed the title
sudipghimire533
changed the title
bors bot
added a commit
that referenced
this pull request
Jul 29, 2021
575: Do no panic when passed empty string as argument. closes #466 r=Emilgardis a=sudipghimire533 When parsing argument `parse()` function in `src/cli.rs` splits the argument string without checking length which results in panic when splitting empty string. This PR pix that issue by introducing `continue` on empty string. Co-authored-by: Sudip Ghimire <[email protected]>
|
Timed out. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 30, 2021
575: Do no panic when passed empty string as argument. closes #466 r=Emilgardis a=sudipghimire533 When parsing argument `parse()` function in `src/cli.rs` splits the argument string without checking length which results in panic when splitting empty string. This PR pix that issue by introducing `continue` on empty string. Co-authored-by: Sudip Ghimire <[email protected]>
|
Build failed:
|
|
bors retry |
|
Build succeeded:
|
|
Thanks for the fix @sudipghimire533 :D |
Alexhuszagh
added
bug
no changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing argument
parse()function insrc/cli.rssplits the argument string without checking length which results in panic when splitting empty string.This PR pix that issue by introducing
continueon empty string.