Remove explicit semver dependency #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
approved these changes
May 27, 2021
bors bot
added a commit
that referenced
this pull request
May 27, 2021
560: Remove explicit semver dependency r=therealprof a=dtolnay This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver. Co-authored-by: David Tolnay <[email protected]>
|
Build failed: |
|
Build failure appears unrelated. + python3 ./repo sync -c bionic
Traceback (most recent call last):
File "/tmp/tmp.f0V4aSzo5t/.repo/repo/main.py", line 627, in <module>
_Main(sys.argv[1:])
...
File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ssh'
The command '/bin/sh -c /android-system.sh arm64' returned a non-zero code: 1 |
|
@dtolnay Yeah, I agree. 🙄 |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 14, 2021
560: Remove explicit semver dependency r=therealprof a=dtolnay This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver. Co-authored-by: David Tolnay <[email protected]>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 25, 2021
560: Remove explicit semver dependency r=therealprof a=dtolnay This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver. Co-authored-by: David Tolnay <[email protected]>
|
Timed out. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2021
560: Remove explicit semver dependency r=therealprof a=dtolnay This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver. Co-authored-by: David Tolnay <[email protected]>
|
Build failed: |
|
bors retry 🤞 |
|
I see now that in #554 we actually do depend on |
|
Build succeeded:
|
Alexhuszagh
added
no changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate only uses semver transitively through the rustc_version crate. It does not need to directly depend on semver.