Add support for more hosts and simplify/unify host support checks #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
previously approved these changes
Feb 20, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 20, 2021
489: Add support for more hosts and simplify/unify host support checks r=reitermarkus a=alex-berger This PR enables more freedom when choosing custom host/target combinations and simplifies (unifies) logic and behavior regarding when to build natively (using local toolchain) and when to use docker image based toolchain. If users explicitly passes `--target ...` option to `cross` it will always use docker image based toolchain (unless a target explicitly opts-out) and only use the local toolchain if `--target` option is not present. Furthermore, no longer make any assumptions about the host, and let users use any host. It is the user's choice and responsibility to choose a working host platform and `cross` should not artificially limit use cases. This PR also addresses: - [436](#436) Co-authored-by: [email protected] <[email protected]>
|
Build failed: |
…more use cases. - Relax host check and allow any host platform.
alex-berger
force-pushed
the
feature/unify-hosts
branch
from
db33fd6 to
188c4bb
Compare
…ll fail to download them.
|
Rebased onto master and all test pass now, can we merge this into master please. |
burrbull
approved these changes
Apr 18, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables more freedom when choosing custom host/target combinations and simplifies (unifies) logic and behavior regarding when to build natively (using local toolchain) and when to use docker image based toolchain. If users explicitly passes
--target ...option tocrossit will always use docker image based toolchain (unless a target explicitly opts-out) and only use the local toolchain if--targetoption is not present.Furthermore, no longer make any assumptions about the host, and let users use any host. It is the user's choice and responsibility to choose a working host platform and
crossshould not artificially limit use cases.This PR also addresses: