-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross subcommands shortcuts #445
Conversation
Thank you for your contribution! This seems like it should be the default behaviour, but should cross maybe support all aliases, including userdefined aliases? In cargo, the b,c,r,t aliases are shadowed by user-defined aliases. |
I agree it makes sense. The issue here is to handle aliases 100% there are a lot of things to account for https://doc.rust-lang.org/cargo/reference/config.html, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
445: Add cross subcommands shortcuts r=Emilgardis a=sigmaSd Hi, this pr adds sub-commands shortcuts `['b','c','r', 't']` to the cli. The main reason is currently the error when using them is misleading. Example: this command: `cross b --target arm-linux-androideabi` outputs this error: `error: linking with `cc` failed: exit code: 1` which took me a while to figure out that cross is not recognizing the sub-command and is falling-back to cargo. Also they are useful to have. Co-authored-by: Nbiba Bedis <[email protected]>
Build failed: |
bors retry |
445: Add cross subcommands shortcuts r=Emilgardis a=sigmaSd Hi, this pr adds sub-commands shortcuts `['b','c','r', 't']` to the cli. The main reason is currently the error when using them is misleading. Example: this command: `cross b --target arm-linux-androideabi` outputs this error: `error: linking with `cc` failed: exit code: 1` which took me a while to figure out that cross is not recognizing the sub-command and is falling-back to cargo. Also they are useful to have. Co-authored-by: Nbiba Bedis <[email protected]>
Build failed:
|
Hi! I just spent a good while tearing my hair out over this, because I was trying to run |
bors r+ |
Build succeeded: |
Hi, this pr adds sub-commands shortcuts
['b','c','r', 't']
to the cli.The main reason is currently the error when using them is misleading.
Example:
this command:
cross b --target arm-linux-androideabi
outputs this error:
error: linking with
ccfailed: exit code: 1
which took me a while to figure out that cross is not recognizing the sub-command and is falling-back to cargo.
Also they are useful to have.