-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: use apt-get --assume-yes
in Dockerfile
#415
README: use apt-get --assume-yes
in Dockerfile
#415
Conversation
This little change makes it even easier for someone to create their own Dockerfile: they simply copy an example and start listing the packages they need. Without `--assume-yes`, `apt-get install` will try to interactively ask for confirmation, and fail since `docker build` runs it in a non-interactive environment.
I think all other occurrences are using |
@reitermarkus I don't really know, I've seen all of the three aliases. I personally think docs should use long options so people don't have to look them up. Then the choice is between I'm okay with changing it to anything else if a reviewer asks for it. |
The main point is that we should be consistent. Feel free to change all Dockerfiles and scripts to use the long option as well. |
This makes it consistent with the example in the README.
Ah, sorry, I somehow misunderstood you and though that you're talking of all the Dockerfiles in existence, not just the ones in this repo. I've changed them all to use The "real" Dockerfiles in this repo also use |
CI error doesn't look related to my changes at all. |
bors try |
tryBuild failed: |
bors retry |
tryBuild succeeded: |
bors r+ |
Build succeeded:
|
Thanks, @Minoru! |
This little change makes it even easier for someone to create their own Dockerfile: they simply copy an example and start listing the packages they need. Without
--assume-yes
,apt-get install
will try to interactively ask for confirmation, and fail sincedocker build
runs it in a non-interactive environment.