Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for i686-apple-darwin. #394

Closed
wants to merge 1 commit into from

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 12, 2020

The High Sierra image on Azure Pipelines is deprecated and testing doesn't work on Mojave.

@reitermarkus reitermarkus requested review from Dylan-DPC-zz and a team as code owners March 12, 2020 04:17
adamgreig
adamgreig previously approved these changes Mar 12, 2020
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 12, 2020
392: Update `arm-unknown-linux-gnueabihf`. r=adamgreig a=reitermarkus

Fixes #391.

393: Update CMake to 3.16.5. r=adamgreig a=reitermarkus



394: Fix CI for `i686-apple-darwin`. r=adamgreig a=reitermarkus



Co-authored-by: Markus Reiter <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 12, 2020

Build failed (retrying...)

  • rust-embedded.cross

@reitermarkus
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Mar 12, 2020

Already running a review

bors bot added a commit that referenced this pull request Mar 12, 2020
377: Avoid pulling if image already exists locally. r=adamgreig a=reitermarkus

This avoids overwriting the local image when making changes to images locally.

393: Update CMake to 3.16.5. r=adamgreig a=reitermarkus



394: Fix CI for `i686-apple-darwin`. r=adamgreig a=reitermarkus



Co-authored-by: Markus Reiter <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 12, 2020

Build failed (retrying...)

  • rust-embedded.cross

bors bot added a commit that referenced this pull request Mar 12, 2020
393: Update CMake to 3.16.5. r=adamgreig a=reitermarkus



394: Fix CI for `i686-apple-darwin`. r=adamgreig a=reitermarkus



Co-authored-by: Markus Reiter <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 12, 2020

Build failed (retrying...)

  • rust-embedded.cross

bors bot added a commit that referenced this pull request Mar 12, 2020
394: Fix CI for `i686-apple-darwin`. r=adamgreig a=reitermarkus



Co-authored-by: Markus Reiter <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 12, 2020

Build failed

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 12, 2020
@reitermarkus reitermarkus changed the title Fix CI for i686-apple-darwin. Remove support for i686-apple-darwin. Mar 12, 2020
@reitermarkus reitermarkus requested a review from adamgreig March 12, 2020 19:06
@reitermarkus reitermarkus deleted the i686-apple-darwin branch March 12, 2020 19:43
@reitermarkus reitermarkus mentioned this pull request Mar 12, 2020
bors bot added a commit that referenced this pull request Mar 12, 2020
396: Fix CI. r=reitermarkus a=reitermarkus

Consolidates #395 and #394.

Co-authored-by: Markus Reiter <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 13, 2020

try

Timed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants