-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message on CI when target = MSVC or Darwin and target = host #1447
Comments
The way to solve this would probably be to add a check in the error path here: Lines 775 to 787 in f272b47
where we check if the target is |
I hit that issue today and got confused indeed :). Many thanks @Emilgardis for the swift help in the matrix channel! |
I hit the same thing. Setting Rather than simply improving the error message, perhaps it would be useful to have an explicit option to allow failing back automatically in such cases? The rationale here is that it is convenient when doing matrix builds which include a variety of targets, some of which require cross and some which do not. Of course it is possible to enumerate which is which in the matrix and avoid the issue, so this is simply for convenience. |
@fujiapple852 an automatic fallback would be the opposite of the intended behaviour. Perhaps a way to say "i dont care about cross not supporting this target, but I do care about other warnings in ci" is needed. I dont like this approach though, the reason for doing this was that cross shouldnt be used in those cases, and some people were/are under the false impression that cross does work for these targets, when it actually doesnt |
With #661, we now error on warnings in CI.
To clear up confusion, we could suggest a fix that just running
cargo
could work, we can also point to https://github.com/cross-rs/cross-toolchains.See discussion
The text was updated successfully, but these errors were encountered: