Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration pattern to be String. #18

Closed
wants to merge 1 commit into from
Closed

Allow configuration pattern to be String. #18

wants to merge 1 commit into from

Conversation

gubarez
Copy link
Contributor

@gubarez gubarez commented Mar 8, 2018

No description provided.

crookedneighbor
crookedneighbor requested changes Mar 8, 2018
View reviewed changes
Copy link
Owner

@crookedneighbor crookedneighbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this behavior?

@gubarez
Copy link
Contributor Author

gubarez commented Mar 9, 2018

Done, please check!

@crookedneighbor
Copy link
Owner

Looks like you opened up a separate pull request instead of applying the test to this one. Can you add the test here instead?

@crookedneighbor crookedneighbor mentioned this pull request Mar 9, 2018
Closed
@crookedneighbor
Copy link
Owner

If you need help with that, let me know.

@gubarez
Copy link
Contributor Author

gubarez commented Mar 30, 2018

Sorry, I don't know how to edit in the same pull request... Could you please check?

@crookedneighbor
Copy link
Owner

Thanks. Released with 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crookedneighbor crookedneighbor crookedneighbor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gubarez @crookedneighbor