New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the jsx-quotes to javascript config #373

Merged

marcospassos merged 2 commits into master from fix/jsx-quotes

Mar 17, 2023

Member

georgekaran commented Mar 17, 2023 •

edited

Loading

Summary

This PR moves jsx-quotes to the javascript config as it wasn't working inside the react config.

Result applying in one of our projects

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings


          Move the jsx-quotes to javascript config

f6ed68f

georgekaran added the bug label

georgekaran requested review from marcospassos and Fryuni

March 17, 2023 12:46

georgekaran self-assigned this


          Allow multiline cases to not have line break

3fd934e

marcospassos merged commit d9be876 into master

marcospassos deleted the fix/jsx-quotes branch

March 17, 2023 20:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug