Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions #195

Open
burrbull opened this issue Nov 17, 2019 · 20 comments
Open

Regressions #195

burrbull opened this issue Nov 17, 2019 · 20 comments

Comments

@burrbull
Copy link
Collaborator

burrbull commented Nov 17, 2019

See below

@burrbull
Copy link
Collaborator Author

1702.00047

изображение

изображение

@burrbull
Copy link
Collaborator Author

burrbull commented Nov 17, 2019

Just open in evince and Ctrl+A, Ctrl+C

On the left is oxidized version.

crlf0710 added a commit that referenced this issue Nov 18, 2019
@crlf0710
Copy link
Owner

From
https://tt.ente.ninja/#/compare/master-a9958b322b9f46bcbd7e064b156362fe989fd8d1/0ba4b44ac313f8636f4927bd658e07ac3527481d

It seems that 1702.00129 & 1702.00351 are fixed. The first file that's a regression is the 1702.00047 mentioned above. Will investigate into it when i got some time.

@crlf0710
Copy link
Owner

I compared the pdf outputs of 1702.00047 file, it seems these two type1 fonts:
MSBM10
LMMathExtension10-Regular
are losing one tounicode cmap entry. There's no other differences. Mmmm. Strange.

@Mrmaxmeier
Copy link
Collaborator

Here's a minimal reproducer reduced from 1702.00102:

\documentclass{article}
\usepackage{amsmath}
\usepackage{amssymb}

\begin{document}
$\widetilde{\mathbb{P}_{x}}$
\end{document}

@burrbull
Copy link
Collaborator Author

burrbull commented Nov 19, 2019

Looking on screenshot above (left oxidized version) it seems to me this is not regression. Looks like something was fixed.

@cormacrelf
Copy link
Collaborator

What about it was fixed? All I can look at is the badly kerned “closure” on the left.

@burrbull
Copy link
Collaborator Author

burrbull commented Nov 22, 2019

I say about screenshots with widetilde.
What "closure" do you say about?

@crlf0710
Copy link
Owner

Actually i debugged the code a little the other day. Seemed nothing badly wrong to me. Next time i'll compile a c version and check out how their traces are different.

@burrbull
Copy link
Collaborator Author

@crlf0710 What tools do you use to compare pdfs?

Can you also compare something from https://tt.ente.ninja/#/compare/1fbc8a7e1adedc2a819bffad0af94f3b04c88750/ed980e087cb84b54b9a2e6fc9bd5dab4c2fce275 ?

@crlf0710
Copy link
Owner

@burrbull To compare pdfs the key point is to force it stop using compressions and binary representations. After that it will be entirely text.
I usually use a tool called mutool from mupdf package to do this.

To convert a file, i run this command.
mutool clean -adfigs <input.pdf> <output.pdf>

After this, i can compare two converted pdfs using any text editor or text diff tool.

@burrbull

This comment has been minimized.

@burrbull
Copy link
Collaborator Author

Regression in 1702.04878 fixed in #227

@burrbull
Copy link
Collaborator Author

burrbull commented Nov 28, 2019

1702.00102 :

Old~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~New
изображение

изображение

Here's a minimal reproducer reduced from 1702.00102:

\documentclass{article}
\usepackage{amsmath}
\usepackage{amssymb}

\begin{document}
$\widetilde{\mathbb{P}_{x}}$
\end{document}

изображение

Was added between 1002e72 and 5fb2205

изображение

изображение

Compare: test_agl...crlf0710:test_agl2

@burrbull
Copy link
Collaborator Author

@pkgw

Looks like problem in tectonic was accidentally solved during oxidize.

@burrbull
Copy link
Collaborator Author

burrbull commented Nov 29, 2019

@Mrmaxmeier can we somehow filter changed files to see are there other bugs?

Maybe with

grep \widetilde TEX_FILE

or

mutool show PDF_FILE grep | grep /tildewider

Now we have 163 changes:
https://tt.ente.ninja/#/compare/master-a9958b322b9f46bcbd7e064b156362fe989fd8d1/16af24cf690177dc82c4f602ae10e73c70adf65d

@burrbull

This comment has been minimized.

@burrbull

This comment has been minimized.

@burrbull

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants