Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add eslint and prettier ? #47

Closed
Lmzd opened this issue Jul 4, 2018 · 6 comments
Closed

Is it possible to add eslint and prettier ? #47

Lmzd opened this issue Jul 4, 2018 · 6 comments

Comments

@Lmzd
Copy link

Lmzd commented Jul 4, 2018

I think it could be a great update, for the structure and the scalability of this open project :)

@Lmzd Lmzd changed the title Is it possible to add a eslint and prettier ? Is it possible to add eslint and prettier ? Jul 4, 2018
@einazare
Copy link
Contributor

einazare commented Jul 4, 2018

Hello @Lmzd ,

And thank you for your interest in using our product.
Could you please show us how we should add eslint or prettier?
Before we've launched this product we've used prettier-cli, so it should have the prettier format.

Best,
Manu

@Lmzd
Copy link
Author

Lmzd commented Jul 4, 2018

nice cause I tried to put eslint with airbnb recommanded and it was one most brainfuck things of last month :)
so if you say i can run lint ci/cd test with only prettier it's also great 👍

kdclaw3 added a commit to kdclaw3/material-dashboard-react that referenced this issue Jul 10, 2018
fixes creativetimofficial#47. eslint and prettier added with react plugin as optional dependencies. Ignores documentation directory. Matches current styling rules in place. To run use npm run-script lint.
@kdclaw3
Copy link

kdclaw3 commented Jul 10, 2018

@Lmzd @einazare I forked and have created a pull request #50 with eslint & prettier that match the current styling rules

@einazare
Copy link
Contributor

Hello @kdclaw3 ,

Thank you for your pull request, i am going to accept it on our next update, hope this is ok with you.

Best,
Manu

@kdclaw3
Copy link

kdclaw3 commented Jul 12, 2018

@Lmzd I updated my fork https://github.com/kdclaw3/material-dashboard-react with a better eslint/prettier implementation it now uses:

  • "eslint:recommended",
  • "plugin:react/recommended",
  • "plugin:prettier/recommended"

to use:
npm run lint:check

@ikowadavies
Copy link

For those using WebStorm, this solution https://www.jetbrains.com/help/webstorm/prettier.html#ws_prettier_install worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants