Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic conflict in accordion buttons #549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iamamritpalrandhawa
Copy link

Fixes

Description

  • In the Choose A License page, there is a section called Confused? Need help? where the elements that look like hyperlinks are actually buttons, which is a UX issue. This PR resolves the problem by making these elements function as accordions, aligning with typical FAQ design practices.

Technical details

  • Replaced the v-btn elements with v-accordion components for better semantic alignment and to resolve the conflict between visual representation (links) and functionality (buttons).
  • Ensured the accordion structure allows for expandable/collapsible sections, providing further information in a popup-like behavior when clicked.
  • Updated styles to retain the hyperlink-like visual cues while adhering to semantic accuracy.

Tests

  • Verify that the Confused? Need help? section is now rendered as an accordion with proper expand/collapse functionality.
  • Ensure that the UX matches typical FAQ design and that there are no regressions in behavior or styling.
  • Validate accessibility (a11y) compliance for the updated components.

Steps to Test:

  • Open the application.
  • Navigate to the Choose A License page and scroll to the Confused? Need help? section.
  • Interact with the accordion elements:
    • Ensure clicking expands and collapses sections correctly.
    • Confirm the information is displayed as expected.
    • Verify no unexpected navigation occurs.

Screenshots

  • Before
    Screenshot 2024-11-25 011444

  • After
    Screenshot 2024-11-25 011429

@iamamritpalrandhawa iamamritpalrandhawa requested review from a team as code owners November 24, 2024 19:47
@iamamritpalrandhawa iamamritpalrandhawa requested review from TimidRobot, possumbilities and akmadian and removed request for a team November 24, 2024 19:47
Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for creativecommons-chooser ready!

Name Link
🔨 Latest commit fd2b1e0
🔍 Latest deploy log https://app.netlify.com/sites/creativecommons-chooser/deploys/674382d8f3578f00086c1245
😎 Deploy Preview https://deploy-preview-549--creativecommons-chooser.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities possumbilities removed request for a team, TimidRobot and akmadian November 25, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Links are actually buttons
1 participant