fix(tests): fix end-to-end test on browserstack

Signed-off-by: Fery Wardiyanto <[email protected]>
creasico · Sep 29, 2023 · ea5b581 · ea5b581
1 parent ed075b2
commit ea5b581
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 12 deletions.
diff --git a/tests/Browser/AuthenticationTest.php b/tests/Browser/AuthenticationTest.php
@@ -17,10 +17,12 @@ public function should_not_be_able_to_authenticate_using_invalid_credential()
         $this->browse(function (Browser $browser) {
             $page = $browser->visit(new Login);
 
-            $page->assertFocused('#username input[type="text"]')
-                ->type('@username', 'johndoe')
+            $page->assertFocused('@username');
+
+            $page->type('@username', 'johndoe')
                 ->type('@password', 'secret')
-                ->pressAndWaitFor('@login');
+                ->press('@login')
+                ->waitFor('.n-form-item-feedback-wrapper');
 
             $page->assertSee(__('auth.failed'));
         });
@@ -39,8 +41,9 @@ public function should_be_able_to_authenticate_using_existing_credential()
         $this->browse(function (Browser $browser) use ($user) {
             $page = $browser->visit(new Login);
 
-            $page->assertFocused('#username input[type="text"]')
-                ->type('@username', $user->name)
+            $page->assertFocused('@username');
+
+            $page->type('@username', $user->name)
                 ->type('@password', 'secret')
                 ->press('@login')
                 ->waitForInertia();

diff --git a/tests/Browser/Pages/ForgotPassword.php b/tests/Browser/Pages/ForgotPassword.php
@@ -36,7 +36,7 @@ public function assert(Browser $browser)
     public function elements()
     {
         return [
-            '@email' => '#email input[type="text"]',
+            '@email' => 'input#email',
         ];
     }
 }
diff --git a/tests/Browser/Pages/HomePage.php b/tests/Browser/Pages/HomePage.php
@@ -2,6 +2,7 @@
 
 namespace Tests\Browser\Pages;
 
+use App\Providers\RouteServiceProvider;
 use Laravel\Dusk\Browser;
 
 class HomePage extends Page
@@ -13,7 +14,7 @@ class HomePage extends Page
      */
     public function url()
     {
-        return '/';
+        return RouteServiceProvider::HOME;
     }
 
     /**

diff --git a/tests/Browser/Pages/Login.php b/tests/Browser/Pages/Login.php
@@ -35,8 +35,8 @@ public function assert(Browser $browser)
     public function elements()
     {
         return [
-            '@username' => '#username input[type="text"]',
-            '@password' => '#password input[type="password"]',
+            '@username' => 'input#username',
+            '@password' => 'input#password',
             '@remember' => '.n-checkbox',
             '@login' => 'button[type=submit]',
         ];

diff --git a/tests/Browser/Pages/Register.php b/tests/Browser/Pages/Register.php
@@ -35,9 +35,10 @@ public function assert(Browser $browser)
     public function elements()
     {
         return [
-            '@email' => '#email input[type="text"]',
-            '@password' => '#password input[type="password"]',
-            '@confirmPassword' => '#confirm-password input[type="password"]',
+            '@username' => 'input#username',
+            '@email' => 'input#email',
+            '@password' => 'input#password',
+            '@confirmPassword' => 'input#confirm_password',
             '@register' => 'button[type=submit]',
         ];
     }