Skip to content

Commit

Permalink
build: Add release-info.json verification to 'make check'
Browse files Browse the repository at this point in the history
This will detect malformed json files and would have prevented the issue
from the previous commit.

Signed-off-by: Christophe Fergeau <[email protected]>
  • Loading branch information
cfergeau authored and gbraad committed Jun 12, 2024
1 parent 37b772f commit 1d023d7
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ vendorcheck:
./verify-vendor.sh

.PHONY: check
check: cross build_e2e_all $(HOST_BUILD_DIR)/crc-embedder test cross-lint vendorcheck build_integration_all
check: cross build_e2e_all $(HOST_BUILD_DIR)/crc-embedder test cross-lint check-release-info vendorcheck build_integration_all

# Start of the actual build targets

Expand Down Expand Up @@ -292,6 +292,9 @@ gen_release_info:
@sed -i s/@GIT_COMMIT_SHA@/$(COMMIT_SHA)/ $(RELEASE_INFO)
@sed -i s/@OPENSHIFT_VERSION@/$(OPENSHIFT_VERSION)/ $(RELEASE_INFO)

check-release-info: gen_release_info
cat $(RELEASE_INFO) |jq .

.PHONY: linux-release-binary macos-release-binary windows-release-binary
linux-release-binary: LDFLAGS+= $(RELEASE_VERSION_VARIABLES)
linux-release-binary: $(BUILD_DIR)/linux-amd64/crc
Expand Down

0 comments on commit 1d023d7

Please sign in to comment.