Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcuts #203

Merged
merged 4 commits into from
Feb 25, 2020
Merged

Add shortcuts #203

merged 4 commits into from
Feb 25, 2020

Conversation

mleo2003
Copy link

@mleo2003 mleo2003 commented Feb 6, 2020

Add shortcuts for copying note title from list, erase a word with standard shortcut.

@mleo2003
Copy link
Author

Added the Control-Delete shortcut as well as Control-Backspace.

This should satisfy #165

@yuuki0xff yuuki0xff self-assigned this Feb 24, 2020
@yuuki0xff
Copy link
Collaborator

Thank you for your contribution.
I found a bug in cmd_text_copy(). In the Linux environment, it always copies the note title on the top of list. The intention is to copy the title of selected note, right?

@mleo2003
Copy link
Author

Ah, yes. That is the intention. I'm not sure why the Linux version is different than the Windows version in this regard. I'll see if I can setup something to test it with.

@mleo2003
Copy link
Author

After a quick check in Windows, I can confirm this is a bug for multiple platforms, and I know why: I'm getting the event data for a click/mouse event, and then applying it to a keyboard shortcut. My original testing was a click, then a Control+C on the item, which works. As it is now, it just copies whichever note title your mouse hovers over, even if not selected...

I'll try to fix, or I can just remove from this PR and add it back later once I actually implement it correctly, instead of copying the click event code right above it...

@mleo2003
Copy link
Author

It helps to just use the built-in idx that is recorded on every note change from that menu, instead of blindly copy/pasting code from other functions...

Should be ready to go @yuuki0xff

@yuuki0xff yuuki0xff merged commit 76e607a into cpbotha:master Feb 25, 2020
@mleo2003 mleo2003 deleted the add-shotcuts branch February 25, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants