Skip to content

Commit

Permalink
trie: remove unused makeHashNode (ethereum#24702)
Browse files Browse the repository at this point in the history
  • Loading branch information
darioush authored and cp-wjhan committed Nov 29, 2022
1 parent 0b88d16 commit 2bc7cba
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions trie/committer.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import (
"sync"

"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/crypto"
"golang.org/x/crypto/sha3"
)

// leafChanSize is the size of the leafCh. It's a pretty arbitrary number, to allow
Expand All @@ -44,18 +42,14 @@ type leaf struct {
// By 'some level' of parallelism, it's still the case that all leaves will be
// processed sequentially - onleaf will never be called in parallel or out of order.
type committer struct {
sha crypto.KeccakState

onleaf LeafCallback
leafCh chan *leaf
}

// committers live in a global sync.Pool
var committerPool = sync.Pool{
New: func() interface{} {
return &committer{
sha: sha3.NewLegacyKeccak256().(crypto.KeccakState),
}
return &committer{}
},
}

Expand Down Expand Up @@ -236,14 +230,6 @@ func (c *committer) commitLoop(db *Database) {
}
}

func (c *committer) makeHashNode(data []byte) hashNode {
n := make(hashNode, c.sha.Size())
c.sha.Reset()
c.sha.Write(data)
c.sha.Read(n)
return n
}

// estimateSize estimates the size of an rlp-encoded node, without actually
// rlp-encoding it (zero allocs). This method has been experimentally tried, and with a trie
// with 1000 leafs, the only errors above 1% are on small shortnodes, where this
Expand Down

0 comments on commit 2bc7cba

Please sign in to comment.