Split the path for accepting a sharing #4503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user has received an email for a sharing, they can go to the preview page. From here, there are two possibilities for accepting the sharing: just creating a shortcut, or the full synchronization. Before this commit, the user was first asked their Cozy URL, and on the OAuth authorize page, they have a checkbox for the synchronize option. Now, the choice is made on the preview page (Drive will add a `shortcut=true` parameter in the query string on the `GET /sharings/:id/discovery` endpoint if needed). And if it is just a shortcut, we will skip the OAuth authorize page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has received an email for a sharing, they can go to the preview page. From here, there are two possibilities for accepting the sharing: just creating a shortcut, or the full synchronization.
Before this commit, the user was first asked their Cozy URL, and on the OAuth authorize page, they have a checkbox for the synchronize option. Now, the choice is made on the preview page (Drive will add a
shortcut=trueparameter in the query string on theGET /sharings/:id/discoveryendpoint if needed). And if it is just a shortcut, we will skip the OAuth authorize page.