This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
closed #275 fix scraiping news #276
Merged
+72
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korosuke613
requested review from
koogawa,
Tatsumi0000,
Morichan,
TakaShinoda and
a team
korosuke613
changed the title
korosuke613
force-pushed
the
ticket-275-fix-scraiping-news
branch
from
f7854ad to
8949ab5
Compare
This was referenced Aug 2, 2020
Morichan
reviewed
Aug 2, 2020
| total = rows.find_element(:tag_name => "td").find_element(:tag_name => "p") | ||
|
|
||
| data_hash = {} | ||
| File.open("data/data.json") do |file| |
There was a problem hiding this comment.
Ruby をよく知らないので質問なのですが、ファイルオープン例外が発生する場合の実装は、必要ないのでしょうか？
There was a problem hiding this comment.
調べてみたのですが、正直よくわかりませんでした。
大丈夫そう
| data_hash["main_summary"]["value"] = total.text.delete(",").to_i | ||
|
|
||
| data_json = JSON.pretty_generate(data_hash, {:indent => " "}) | ||
| File.open("data/data.json", mode = "w") { |f| |
There was a problem hiding this comment.
調べてみたのですが、正直よくわかりませんでした。
大丈夫そう
korosuke613
force-pushed
the
ticket-275-fix-scraiping-news
branch
from
c202128 to
6f9fbd7
Compare
|
もう1つの方を見て気づいたのですが、スネークケースとキャメルケースが混ざってます。 |
直します |
|
@Morichan キャメルケースに統一しました |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決する issue / Resolved Issues
📝 関連する issue / Related Issues
⛏ 変更内容 / Details of Changes
📸 スクリーンショット / Screenshots