Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

お知らせが無いときのスクレイピングが失敗するのを修正 #250

Merged
merged 5 commits into from
May 30, 2020

Conversation

koogawa
Copy link
Member

@koogawa koogawa commented May 29, 2020

👏 解決する issue / Resolved Issues

📝 関連する issue / Related Issues

⛏ 変更内容 / Details of Changes

  • お知らせ用の table が存在しないときは、処理を中断するように修正

📸 スクリーンショット / Screenshots

@koogawa koogawa self-assigned this May 29, 2020
@@ -26,7 +26,7 @@ jobs:
gem install bundler
bundle update --bundler
bundle install
ruby scraping.rb
ruby scrapingSource/scraping.rb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

スクリプトの場所を scrapingSource ディレクトリ以下にまとめました

@koogawa koogawa requested a review from a team May 29, 2020 16:25
Copy link
Member

@korosuke613 korosuke613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ありがとうございます!

@korosuke613 korosuke613 merged commit 12f424d into development May 30, 2020
@korosuke613 korosuke613 mentioned this pull request Jul 6, 2020
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

お知らせが無いときスクレイピングが失敗する
2 participants