Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to strict mode (through test/unit/specs). #1183

Closed
NodeGuy opened this issue Aug 27, 2018 · 3 comments
Closed

Convert to strict mode (through test/unit/specs). #1183

NodeGuy opened this issue Aug 27, 2018 · 3 comments
Assignees
Labels

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 27, 2018

Convert all files below (and any new ones in the relevant directories) to strict mode by adding "use strict" as the first line and correct any strict mode violations that occur as a result.

archive/components/CardBalance.spec.js
archive/components/CardNew.spec.js
archive/components/NiCards.spec.js
archive/components/NiTag.spec.js
archive/components/ToggleBtn.spec.js
jest.config.js
tasks/build/local/build.js
tasks/common.js
tasks/test-build.js
tasks/testnet.js
tasks/windows-installer.js
test/e2e/common.js
test/e2e/init.js
test/e2e/preferences.js
test/e2e/signin.js
test/e2e/staking.js
test/e2e/wallet.js
test/unit/coverage/lcov-report/block-navigation.js
test/unit/coverage/lcov-report/prettify.js
test/unit/coverage/lcov-report/sorter.js
test/unit/helpers/console_error_throw.js
test/unit/helpers/electron_mock.js
test/unit/helpers/fixed_time.js
test/unit/helpers/fs-mock.js
test/unit/helpers/genesis_mock.js
test/unit/helpers/node_mock.js
test/unit/helpers/vuex-helpers.js
test/unit/helpers/vuex-setup.js
test/unit/specs/App.spec.js
test/unit/specs/addressbook.spec.js
test/unit/specs/build.spec.js
@NodeGuy NodeGuy added the design-work-needed 🎨 issues that require design work before development label Aug 27, 2018
@NodeGuy NodeGuy mentioned this issue Aug 27, 2018
5 tasks
@jbibla
Copy link
Collaborator

jbibla commented Sep 4, 2018

@NodeGuy is there a reason you added the design label?

@NodeGuy
Copy link
Contributor Author

NodeGuy commented Sep 4, 2018

No, I must have fat-fingered it.

https://www.youtube.com/watch?v=OqjF7HKSaaI

@NodeGuy NodeGuy removed the design-work-needed 🎨 issues that require design work before development label Sep 4, 2018
@jbibla
Copy link
Collaborator

jbibla commented Sep 5, 2018

wonderful reference, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants