Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require strict mode. #1051

Closed
5 tasks
NodeGuy opened this issue Jul 30, 2018 · 5 comments
Closed
5 tasks

Require strict mode. #1051

NodeGuy opened this issue Jul 30, 2018 · 5 comments

Comments

@nylira nylira removed the discuss label Aug 7, 2018
@jbibla jbibla added the split 🍌 issues that need to be split into several smaller issues with reduced scope label Aug 21, 2018
@fedekunze
Copy link
Contributor

@NodeGuy does this just require to add "use strict"; to the beginning of each file ?

@fedekunze
Copy link
Contributor

@jbibla do you remember why do we need to split this issue ?

@NodeGuy
Copy link
Contributor Author

NodeGuy commented Aug 27, 2018

We need to split this issue because if we make strict mode mandatory for all files then we're going to get a ton of non-compliance issues that need to be fixed all at once. Today I'm going to compile a list of all of the JavaScript files and create new issues to tackle groups of them at a time. Once all of the files are in compliance then we can make the ESLint change.

@NodeGuy NodeGuy added blocked ✋ issues blocked by other implementations/issues and removed split 🍌 issues that need to be split into several smaller issues with reduced scope labels Aug 27, 2018
@faboweb
Copy link
Collaborator

faboweb commented Aug 28, 2018

I consider this ticket done in this sprint. The scope was to split it.

@faboweb faboweb added epic and removed blocked ✋ issues blocked by other implementations/issues labels Aug 28, 2018
@faboweb faboweb added low priority has been discussed, will be addressed later and removed low priority has been discussed, will be addressed later labels Sep 20, 2018
@NodeGuy NodeGuy removed their assignment Oct 8, 2018
@NodeGuy
Copy link
Contributor Author

NodeGuy commented Oct 23, 2018

Closing because Babel is already enabling strict mode for us with the es2015 preset. We should open this again in the future if we stop using Babel (or that preset).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants