Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #24

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Improvements #24

merged 8 commits into from
Jun 19, 2024

Conversation

chcmedeiros
Copy link

@chcmedeiros chcmedeiros commented Oct 11, 2023 •
edited
Loading

  • remove old v1 code
  • include zondax/ledger-js package
  • update structure and clean code to use functionalities from ledger-js
  • remove deprecated vue example
  • update testing removing the need of the device and including a mocker with APDU responses from ledger-cosmos testing

@chcmedeiros chcmedeiros requested a review from ftheirs October 11, 2023 16:57
@chcmedeiros chcmedeiros marked this pull request as draft October 11, 2023 17:00
@chcmedeiros chcmedeiros marked this pull request as ready for review October 12, 2023 15:04
@chcmedeiros chcmedeiros requested a review from jleni June 19, 2024 10:42
jleni
jleni requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@jleni jleni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small suggested change! but this is definitely a great improvement!! Great work!

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/consts.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
tests/test_integration.test.ts Show resolved Hide resolved
@chcmedeiros chcmedeiros requested a review from jleni June 19, 2024 11:17
@jleni jleni merged commit 97dfbb8 into master Jun 19, 2024
2 checks passed
@jleni jleni deleted the improvements branch September 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleni jleni jleni approved these changes

@ftheirs ftheirs Awaiting requested review from ftheirs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chcmedeiros @jleni