Merge the *-ics variations into the mainline Cosmos SDK #828
Comments
AaronKutch
added
type: bug
|
I think that we should instead get the needed changes into the next version of the sdk. Well, I suppose that we need docs too, but well, here's a comparison for you: https://docs.google.com/document/d/1ljXZkdbd7g0UjcWlTaigFycfpSlZfN3uNhTXiq6gbVE/edit?usp=sharing It's in the SDK section of the document. |
AaronKutch
changed the title
|
So, right now there are both PRs for 0.45.15-ics and 0.47 open with both of them seeming to be close to completion. Just to make sure, there is going to be a point release using 0.45.15-ics before 0.47? Although, we may want to jump straight to 0.47 anyway since 0.45.15 is supposed to be the last point release for 0.45.x and has some weird stuff in it |
|
Cosmos-SDK 0.47.x already contains all needed interfaces for ICS, for example in this file. The 0.45.x-ics backports are being maintained since 0.47.x was not ready at launch and audit of ICS. As for which version of the SDK you should base a consumer chain on, we are currently supporting 0.45.x-ics. There are several third parties working on upgrades to 0.47.x, but we do not yet officially support it. |
## Description closes: cosmos#828 ### Commit Message / Changelog Entry ```bash imp(api!): rename `IsBound` to `HasCapability` for IBC application modules ``` see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples) --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)). - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package). - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`). - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review. - [ ] Re-reviewed `Files changed` in the Github PR explorer. - [ ] Review `Codecov Report` in the comment section below once CI passes.
Hello, we are planning to use interchain-security v1.1, and I presume that we should rebase our slightly customized SDK on
v0.45.13-ics, which is what is used in this repo'sgo.mod. The first strange thing is a "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository" warning. This repo is directly undercosmos/, so it should be a branch that completely exists on the cosmos-sdk repo? When I runmake testonv0.45.13-ics(at commit d6c8598683ce1ac8efd39941109eae78b8211ddf), I get some test failures related to hashes. Is the *-ics series going to eventually be merged with the main series?edit: I just remembered that the hash change is some spurious thing (?) related to having a high enough Go version cosmos/cosmos-sdk#13355
The text was updated successfully, but these errors were encountered: