Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS-29: updates based on current implementation #779

Merged
merged 10 commits into from
Jul 5, 2022

Conversation

crodriguezvega
Copy link
Contributor

No description provided.

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @crodriguezvega , a couple quick changes

spec/app/ics-029-fee-payment/README.md Show resolved Hide resolved
spec/app/ics-029-fee-payment/README.md Outdated Show resolved Hide resolved
spec/app/ics-029-fee-payment/README.md Outdated Show resolved Hide resolved
spec/app/ics-029-fee-payment/README.md Outdated Show resolved Hide resolved
spec/app/ics-029-fee-payment/README.md Outdated Show resolved Hide resolved
spec/app/ics-029-fee-payment/README.md Outdated Show resolved Hide resolved
spec/app/ics-029-fee-payment/README.md Outdated Show resolved Hide resolved
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crodriguezvega !

Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spec/app/ics-029-fee-payment/README.md Outdated Show resolved Hide resolved
spec/app/ics-029-fee-payment/README.md Outdated Show resolved Hide resolved
@crodriguezvega crodriguezvega merged commit e5f3b45 into master Jul 5, 2022
@crodriguezvega crodriguezvega deleted the carlos/update-ics29 branch July 5, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants