Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated description for optimistic send #1173

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix outdated description for optimistic send #1173

merged 3 commits into from
Dec 19, 2024

Conversation

bluele
Copy link
Contributor

@bluele bluele commented Dec 4, 2024

fix #1170

damiannolan
damiannolan reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would suggest adding an amendment to the "History" section at the bottom of the document.

@bluele
update history in ics-004
be6bd7d 
Signed-off-by: Jun Kimura <[email protected]>
sangier
sangier approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@sangier sangier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catch @bluele !

@AdityaSripal AdityaSripal merged commit 23383e5 into cosmos:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiannolan damiannolan damiannolan left review comments

@sangier sangier sangier approved these changes

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@angbrav angbrav Awaiting requested review from angbrav angbrav is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Clarification on support for optimistic packet sending in ICS-004
4 participants
@bluele @damiannolan @AdityaSripal @sangier