-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude ChannelEnd
from MsgChannelOpenInit
and MsgChannelOpenTry
#327
Conversation
Codecov ReportBase: 63.69% // Head: 62.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 63.69% 62.94% -0.75%
==========================================
Files 124 124
Lines 13773 13967 +194
==========================================
+ Hits 8773 8792 +19
- Misses 5000 5175 +175
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b4bdec4
to
fc69360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but let's wait for #328 to be merged first as there'll probably merge conflicts/tiny things to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
#327) * Exclude ChannelEnd from MsgChannelOpenInit and MsgChannelOpenTry * Apply naming convention on connection_hops * Revise naming of some fields * changelog fix Co-authored-by: Philippe Laferriere <[email protected]>
Closes: #20
Side effect
Bringing
ChannelEnd
fields along with including proofs inside the struct of messages, adds#allow(clippy::too_many_arguments)]
forMsgChannelOpenTry
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.