Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ChannelEnd from MsgChannelOpenInit and MsgChannelOpenTry #327

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Jan 6, 2023

Closes: #20

Side effect

Bringing ChannelEnd fields along with including proofs inside the struct of messages, adds #allow(clippy::too_many_arguments)] for MsgChannelOpenTry


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani self-assigned this Jan 6, 2023
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 63.69% // Head: 62.94% // Decreases project coverage by -0.74% ⚠️

Coverage data is based on head (5fe0093) compared to base (aa97ced).
Patch coverage: 73.46% of modified lines in pull request are covered.

❗ Current head 5fe0093 differs from pull request most recent head dc3ff73. Consider uploading reports for the commit dc3ff73 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   63.69%   62.94%   -0.75%     
==========================================
  Files         124      124              
  Lines       13773    13967     +194     
==========================================
+ Hits         8773     8792      +19     
- Misses       5000     5175     +175     
Impacted Files Coverage Δ
...bc/src/core/ics04_channel/handler/chan_open_ack.rs 89.24% <ø> (ø)
crates/ibc/src/core/ics26_routing/handler.rs 91.11% <ø> (-0.20%) ⬇️
.../ibc/src/core/ics04_channel/msgs/chan_open_init.rs 64.28% <58.62%> (-25.37%) ⬇️
...s/ibc/src/core/ics04_channel/msgs/chan_open_try.rs 69.79% <67.64%> (-23.20%) ⬇️
...bc/src/core/ics04_channel/handler/chan_open_try.rs 86.20% <85.71%> (-0.46%) ⬇️
...c/src/core/ics04_channel/handler/chan_open_init.rs 86.04% <87.50%> (ø)
crates/ibc/src/core/ics04_channel/channel.rs 54.01% <100.00%> (ø)
crates/ibc/src/core/ics04_channel/handler.rs 86.17% <100.00%> (-0.47%) ⬇️
...s/ibc/src/core/ics04_channel/msgs/chan_open_ack.rs 69.44% <0.00%> (-24.90%) ⬇️
...c/src/core/ics04_channel/msgs/chan_open_confirm.rs 69.49% <0.00%> (-23.70%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Farhad-Shabani Farhad-Shabani force-pushed the farhad/20-discard-channelend branch from b4bdec4 to fc69360 Compare January 6, 2023 03:27
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review January 6, 2023 18:03
@Farhad-Shabani Farhad-Shabani requested a review from plafer January 6, 2023 18:03
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

crates/ibc/src/core/ics04_channel/msgs/chan_open_init.rs Outdated Show resolved Hide resolved
crates/ibc/src/core/ics04_channel/msgs/chan_open_init.rs Outdated Show resolved Hide resolved
crates/ibc/src/core/ics04_channel/msgs/chan_open_init.rs Outdated Show resolved Hide resolved
crates/ibc/src/core/ics04_channel/msgs/chan_open_try.rs Outdated Show resolved Hide resolved
crates/ibc/src/core/ics04_channel/msgs/chan_open_try.rs Outdated Show resolved Hide resolved
crates/ibc/src/core/ics04_channel/msgs/chan_open_try.rs Outdated Show resolved Hide resolved
crates/ibc/src/core/ics04_channel/msgs/chan_open_try.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but let's wait for #328 to be merged first as there'll probably merge conflicts/tiny things to fix

@plafer plafer mentioned this pull request Jan 9, 2023
7 tasks
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@plafer plafer merged commit 78297c3 into main Jan 9, 2023
@plafer plafer deleted the farhad/20-discard-channelend branch January 9, 2023 18:47
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
#327)

* Exclude ChannelEnd from MsgChannelOpenInit and MsgChannelOpenTry

* Apply naming convention on connection_hops

* Revise naming of some fields

* changelog fix

Co-authored-by: Philippe Laferriere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: MsgChannelOpenInit and MsgChannelOpenTry should not contain a ChannelEnd
2 participants