-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the function parameters in the Reader trait should be used with the reference modifier #313
Conversation
Codecov ReportBase: 66.26% // Head: 66.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
+ Coverage 66.26% 66.31% +0.05%
==========================================
Files 125 125
Lines 12911 12922 +11
==========================================
+ Hits 8555 8569 +14
+ Misses 4356 4353 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this much-needed change.
Can you add a changelog entry? Then we'll be ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
…he reference modifier (#313) * the function parameters in the Reader trait used with the reference modifier * fix clippy * Create 304-reader-function-use-reference-modifier.md
Closes: #304
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.