Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the function parameters in the Reader trait should be used with the reference modifier #313

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

DaviRain-Su
Copy link
Contributor

Closes: #304

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 66.26% // Head: 66.31% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (f245875) compared to base (c58cdf5).
Patch coverage: 83.70% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   66.26%   66.31%   +0.05%     
==========================================
  Files         125      125              
  Lines       12911    12922      +11     
==========================================
+ Hits         8555     8569      +14     
+ Misses       4356     4353       -3     
Impacted Files Coverage Δ
crates/ibc/src/core/ics02_client/context.rs 85.96% <ø> (ø)
.../ibc/src/core/ics02_client/handler/misbehaviour.rs 89.06% <ø> (ø)
...s/ibc/src/clients/ics07_tendermint/client_state.rs 56.02% <60.00%> (ø)
crates/ibc/src/test_utils.rs 73.66% <60.00%> (ø)
crates/ibc/src/mock/context.rs 74.91% <72.09%> (+0.06%) ⬆️
crates/ibc/src/core/ics04_channel/context.rs 74.54% <77.77%> (ø)
...ibc/src/core/ics02_client/handler/update_client.rs 85.29% <100.00%> (ø)
crates/ibc/src/core/ics03_connection/context.rs 100.00% <100.00%> (ø)
...src/core/ics03_connection/handler/conn_open_ack.rs 92.56% <100.00%> (ø)
...core/ics03_connection/handler/conn_open_confirm.rs 100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this much-needed change.

Can you add a changelog entry? Then we'll be ready to merge.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@plafer plafer merged commit 968e553 into cosmos:main Jan 4, 2023
@DaviRain-Su DaviRain-Su deleted the fix-304 branch January 5, 2023 03:03
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
…he reference modifier (#313)

* the function parameters in the Reader trait used with the reference modifier

* fix clippy

* Create 304-reader-function-use-reference-modifier.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants