Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding helper fn to generate capability name for testing #776

Merged
merged 10 commits into from
Jan 21, 2022
Merged

feat: adding helper fn to generate capability name for testing #776

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b6258a
feat: adding helper fn to generate cap name for testing
seantking Jan 20, 2022
7e80dca
fix: refactoring tests to use new helper in Mock package
seantking Jan 20, 2022
b3fcc38
fix: comment
seantking Jan 20, 2022
7f5e704
fix: remove unused fn
seantking Jan 20, 2022
41b9aa0
Merge branch 'main' into sean/issue#755-add-cap-helper
seantking Jan 20, 2022
2264893
Update testing/mock/ibc_module.go
seantking Jan 21, 2022
9b0359b
Update testing/mock/ibc_module_test.go
seantking Jan 21, 2022
ffe1249
adding additional helpers for ack + timeout
seantking Jan 21, 2022
4ce0a1b
chore: changelog
seantking Jan 21, 2022
3147bbf
nit: err syntax
seantking Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (transfer) [\#517](https://github.com/cosmos/ibc-go/pull/517) Separates the ICS 26 callback functions from `AppModule` into a new type `IBCModule` for ICS 20 transfer.
* (modules/core/02-client) [\#536](https://github.com/cosmos/ibc-go/pull/536) `GetSelfConsensusState` return type changed from bool to error.
* (channel) [\#644](https://github.com/cosmos/ibc-go/pull/644) Removes `CounterpartyHops` function from the ChannelKeeper.
* (testing) [\#776](https://github.com/cosmos/ibc-go/pull/776) Adding helper fn to generate capability name for testing callbacks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late now, but I think this changelog entry could have been a little more specific, at least indicating this is to be only used for the mock testing module



### State Machine Breaking

Expand Down