Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for v2 transfer vesting account #7688

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

gjermundgaraba
Copy link
Contributor

Description

Adds tests for v2 transfer module with vesting accounts.

Needed some more capabilities in the testing suite. Let me know if my approach is alright.

closes: #7658


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@AdityaSripal
Copy link
Member

Looks good to me, I suppose we should have those testing functions anyway

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes make sense to me, nice! Function docs need updating/to be added though.

Would also be nice to add these to the changelog since testing is very commonly consumed by people. (That final point though could generally be added when changelog for ibc-eureka changes is done)

Copy link

@DimitrisJim
Copy link
Contributor

Markdown link checker failure is addressed in SDK pr iirc!

@gjermundgaraba gjermundgaraba merged commit 8d66911 into feat/ibc-eureka Dec 17, 2024
65 of 66 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/7658-with-eureka-port branch December 17, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for transfer entire balance for vesting accounts
3 participants