chore: add telemetry reporting for packet methods #7673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
AdityaSripal and
damiannolan
as code owners
DimitrisJim
commented
Dec 12, 2024
| @@ -226,6 +226,8 @@ func (k *Keeper) Acknowledgement(ctx context.Context, msg *types.MsgAcknowledgem | |||
| } | |||
| } | |||
|
|
|||
| defer telemetry.ReportAcknowledgePacket(msg.Packet) | |||
There was a problem hiding this comment.
defer call already existed for recv
Comment on lines
+18
to
+21
| telemetry.NewLabel(ibcmetrics.LabelSourcePort, payload.SourcePort), | ||
| telemetry.NewLabel(ibcmetrics.LabelSourceChannel, packet.SourceChannel), | ||
| telemetry.NewLabel(ibcmetrics.LabelDestinationPort, payload.DestinationPort), | ||
| telemetry.NewLabel(ibcmetrics.LabelDestinationChannel, packet.DestinationChannel), |
There was a problem hiding this comment.
kept same labels here, unsure if more/less is needed.
There was a problem hiding this comment.
I would imagine it's fine. If we need more, someone will probably tell us.
|
gjermundgaraba
approved these changes
Dec 13, 2024
Comment on lines
+18
to
+21
| telemetry.NewLabel(ibcmetrics.LabelSourcePort, payload.SourcePort), | ||
| telemetry.NewLabel(ibcmetrics.LabelSourceChannel, packet.SourceChannel), | ||
| telemetry.NewLabel(ibcmetrics.LabelDestinationPort, payload.DestinationPort), | ||
| telemetry.NewLabel(ibcmetrics.LabelDestinationChannel, packet.DestinationChannel), |
There was a problem hiding this comment.
I would imagine it's fine. If we need more, someone will probably tell us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7437
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.